| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Reduce TupleHashEntryData struct size by half |
| Date: | 2025-06-13 06:33:56 |
| Message-ID: | CAHut+PspbHQmRCBL1c-opoJeTUKUaFFfUQJd2rhDZqwUrWCi7w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
I was looking at this code recently and noticed the following.
Although the commit [1] removed the ->additional field, some function
comments were not updated to reflect this, so now they seemed a bit
stale.
1. BuildTupleHashTable(...) still says:
----------
...
* additionalsize: size of data stored in ->additional
...
----------
2. Simiarly, LookupTupleHashEntry(...) still says:
----------
...
* false if it existed already. ->additional_data in the new entry has
* been zeroed.
...
----------
======
[1] https://github.com/postgres/postgres/commit/626df47ad9db809dc8f93330175ab95b75914721
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shveta malik | 2025-06-13 06:52:10 | Re: Conflict detection for update_deleted in logical replication |
| Previous Message | jian he | 2025-06-13 06:29:23 | Re: Add SPLIT PARTITION/MERGE PARTITIONS commands |