Re: tablesync copy ignores publication actions

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: tablesync copy ignores publication actions
Date: 2022-06-16 00:37:09
Message-ID: CAHut+Psp+S-jdxz_5bqyUzLaVwrQwWfg=Yc7OODczerLF3cRgQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 15, 2022 at 5:05 PM shiy(dot)fnst(at)fujitsu(dot)com
<shiy(dot)fnst(at)fujitsu(dot)com> wrote:
>
...
> Thanks for updating the patch. Two comments:
>
> 1.
> + it means the copied table <literal>t3</literal> contains all rows even when
> + they do not patch the row filter of publication <literal>pub3b</literal>.
>
> Typo. I think "they do not patch the row filter" should be "they do not match
> the row filter", right?
>
> 2.
> @@ -500,7 +704,6 @@
> </para>
> </listitem>
> </itemizedlist></para>
> -
> </sect2>
>
> <sect2 id="logical-replication-row-filter-examples">
>
> It seems we should remove this change.
>

Thank you for your review comments. Those reported mistakes are fixed
in the attached patch v3.

------
Kind Regards,
Peter Smith.
Fujitsu Australia

Attachment Content-Type Size
v3-0001-PGDOCS-tablesync-ignores-publish-operation.patch application/octet-stream 9.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2022-06-16 00:59:52 Re:
Previous Message Mark Dilger 2022-06-16 00:21:56 Modest proposal to extend TableAM API for controlling cluster commands