Re: [DOC] Update ALTER SUBSCRIPTION documentation v3

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: Robert Sjöblom <robert(dot)sjoblom(at)fortnox(dot)se>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [DOC] Update ALTER SUBSCRIPTION documentation v3
Date: 2023-05-17 06:27:15
Message-ID: CAHut+PsmE=XvkphA=UeGjMQqVfjnca_d2oW7y3JKvWdwNbgtQA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, May 17, 2023 at 2:53 PM Robert Sjöblom
<robert(dot)sjoblom(at)fortnox(dot)se> wrote:
>
> Den ons 17 maj 2023 kl 03:18 skrev Peter Smith <smithpb2250(at)gmail(dot)com>:
> >
> > + errhint("Use %s to disassociate the subscription from the slot after
> > disabling the subscription.",
> >
> > IMO it looked strange having the word "subscription" 2x in the same sentence.
> >
> > Maybe you can reword the errhint like:
> >
> > BEFORE
> > "Use %s to disassociate the subscription from the slot after disabling
> > the subscription."
> >
> > SUGGESTION#1
> > "Disable the subscription, then use %s to disassociate it from the slot."
> >
> > SUGGESTION#2
> > "After disabling the subscription use %s to disassociate it from the slot."
> >
> > ~~~
> >
> > BTW, it is a bit difficult to follow this thread because the subject
> > keeps changing.
> >
> > ------
> > Kind Regards,
> > Peter Smith.
> > Fujitsu Australia
>
> Good catch, I definitely agree. I'm sorry about changing the subject
> line, I'm unaccustomed to mailing lists -- I'll leave it as it is now.
>
> Attached is the revised version.
>

v4 looks good to me.

------
Kind Regards,
Peter Smith.
Fujitsu Australia

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Drouvot, Bertrand 2023-05-17 06:29:42 Re: Introduce WAIT_EVENT_EXTENSION and WAIT_EVENT_BUFFER_PIN
Previous Message Michael Paquier 2023-05-17 06:18:58 Re: Add LZ4 compression in pg_dump