| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
| Subject: | Re: Handle infinite recursion in logical replication setup |
| Date: | 2022-08-31 06:15:29 |
| Message-ID: | CAHut+PskcZ8Go0c9LSEFYbnATohY+x2xjmPcuR9FCJJrOzjzMg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Here are some review comments for patch v43-0002:
======
1. doc/src/sgml/ref/create_subscription.sgml
@@ -403,7 +403,9 @@ CREATE SUBSCRIPTION <replaceable
class="parameter">subscription_name</replaceabl
warning to notify the user to check the publisher tables. Before continuing
with other operations the user should check that publisher tables did not
have data with different origins to prevent data inconsistency issues on the
- subscriber.
+ subscriber. Refer to <xref linkend="replication-between-primaries"/> for
+ how <literal>copy_data</literal> and <literal>origin</literal> can be used
+ to set up replication between primaries.
</para>
Regarding my earlier v43-0001 review (see [1] comment #2) perhaps
another pg docs section should be added in the
logical-replication.sgml (e.g. "Specifying origins during CREATE
SUBSCRIPTION"), so then this Notes text also should have more added to
it.
SUGGESTION
Refer to <XXX_REF> for details about potential initialization
inconsistency warnings using origin=NONE.
Refer to <YYY_REF> for how copy_data and origin can be used to set up
replication between primaries.
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2022-08-31 06:28:46 | Re: New strategies for freezing, advancing relfrozenxid early |
| Previous Message | Michael Paquier | 2022-08-31 06:09:16 | Re: [PATCH] Add native windows on arm64 support |