| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: src/bin/pg_upgrade/t/004_subscription.pl test comment fix |
| Date: | 2024-01-31 06:18:51 |
| Message-ID: | CAHut+PsiW15N6nsC4D5Ey7R9g84-R2eR=hj7+sHz8d6fJA1Fkg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 31, 2024 at 4:51 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Wed, 31 Jan 2024 at 10:27, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> > Hi,
> >
> > PSA a small fix for a misleading comment found in the pg_upgrade test code.
>
> Is the double # intentional here, as I did not see this style of
> commenting used elsewhere:
> +# # Upgraded regress_sub1 should still have enabled and failover as true.
> +# # Upgraded regress_sub2 should still have enabled and failover as false.
>
Unintentional caused by copy/paste. Thanks for reporting. I will post
a fixed patch tomorrow.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2024-01-31 06:39:59 | Re: Oversight in reparameterize_path_by_child leading to executor crash |
| Previous Message | Hayato Kuroda (Fujitsu) | 2024-01-31 06:12:17 | RE: Documentation to upgrade logical replication cluster |