| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Add common function ReplicationOriginName. |
| Date: | 2022-09-19 02:35:25 |
| Message-ID: | CAHut+Psa8hhfSE6ozUK-ih7GkQziAVAf4f3bqiXEj2nQiu-43g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi.
There are already multiple places that are building the subscription
origin name, and there are more coming with some new patches [1] doing
the same:
e.g.
snprintf(originname, sizeof(originname), "pg_%u", subid);
~~
IMO it is better to encapsulate this name formatting in common code
instead of the format string being scattered around the place.
PSA a patch to add a common function ReplicationOriginName. This is
the equivalent of a similar function for tablesync
(ReplicationOriginNameForTablesync) which already existed.
Kind Regards,
Peter Smith.
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Add-common-function-ReplicationOriginName.patch | application/octet-stream | 3.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | houzj.fnst@fujitsu.com | 2022-09-19 02:44:12 | Fix typos in code comments |
| Previous Message | Andres Freund | 2022-09-19 00:29:43 | Re: [RFC] building postgres with meson - v13 |