Re: Improve CREATE/ALTER PUBLICATION syntax for EXCEPT

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: pgsql-docs(at)lists(dot)postgresql(dot)org
Subject: Re: Improve CREATE/ALTER PUBLICATION syntax for EXCEPT
Date: 2026-07-23 06:52:16
Message-ID: CAHut+PsT6Jm+O2fhzYYyG9yPo2Z=Gs8kNsUnLBe26ez97qvoPw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-docs

Some review comments for v2.

1. (rendered from patch)
Likewise altering a publication to set ALL TABLES, to change the
EXCEPT list, or to set or unset ALL SEQUENCES also requires the
subscriber to refresh the publication.

~

The text there says "set or unset" ALL SEQUENCES, but it only says
"set" ALL TABLES.

AFAIK the SET will *replace* the kind of publication.

e.g.1
Assuming we start out a publication that has FOR ALL SEQUENCES
Then, ALTER ... SET ALL TABLES will effectively "unset" ALL SEQUENCES

e.g.2
Assuming we start out a publication that has FOR ALL TABLES
Then, ALTER ... SET ALL SEQUENCES will effectively "unset" ALL TABLES

~

It might be better not to say "unset" at all, but if you want to keep
it then maybe it ought to be said in both places.

~~~

2.
(probably out of scope for this patch)

IMO this "Description" is becoming overly-complicated by saying "Note
that" and "Note also that" etc.

It seems to me that anything that is a note belongs in the "Notes"
section (but the "Notes" section is strangely missing from this page)
so that the "Description" section can be much less cluttered. e.g.
Compare with Description for CREATE PUBLICATION page.

Anyway, perhaps refactoring to make a new "Notes" section is a patch
for another day, not now.

======
Kind Regards,
Peter Smith.
Fujitsu Australia

In response to

Browse pgsql-docs by date

  From Date Subject
Next Message Michael Paquier 2026-07-23 07:23:00 Re: Add "io worker" as backend_type to the pg_stat_activity documentation
Previous Message Fujii Masao 2026-07-23 05:47:19 Re: Improve CREATE/ALTER PUBLICATION syntax for EXCEPT