Fix a recent "shadow warning" in subscriptioncmds.c

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Fix a recent "shadow warning" in subscriptioncmds.c
Date: 2025-11-28 03:59:01
Message-ID: CAHut+PsF8R0Bt4J3c92+T2F0mun0rRfK=-GH+iBv2s-O8ahJJw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I noticed that recently, a shadow warning has crept into the code I am building.

----------
subscriptioncmds.c:1125:30: warning: declaration of ‘rel’ shadows a
previous local [-Wshadow]
foreach_ptr(SubRemoveRels, rel, sub_remove_rels)
^
../../../src/include/nodes/pg_list.h:482:20: note: in definition of
macro ‘foreach_internal’
for (type pointer var = 0, pointer var##__outerloop = (type pointer) 1; \
^
subscriptioncmds.c:1125:3: note: in expansion of macro ‘foreach_ptr’
foreach_ptr(SubRemoveRels, rel, sub_remove_rels)
^
subscriptioncmds.c:934:11: warning: shadowed declaration is here [-Wshadow]
Relation rel = NULL;
^
----------

This seems to have been introduced recently by the REFRESH SEQUENCES
commit f0b3573.

IIUC, this particular case is harmless, but IMO it's still worth
fixing to avoid recurring doubts about potential issues every time it
appears.

PSA patch v1 to address the warning.

======
Kind Regards,
Peter Smith.
Fujitsu Australia

Attachment Content-Type Size
v1-0001-Fix-shadow-warning-in-subscriptioncmds.c.patch application/octet-stream 1.6 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-11-28 04:05:55 Re: Move WAL/RMGR sequence code into its own file and header
Previous Message Peter Smith 2025-11-28 03:49:10 Re: Simplify code building the LR conflict messages