Re: CREATE/ALTER PUBLICATION improvements for syntax synopsis

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: CREATE/ALTER PUBLICATION improvements for syntax synopsis
Date: 2025-11-20 01:41:50
Message-ID: CAHut+PsB1_-=A4fjy4SqyoQ3agCj3woBMvp0F9GPxP1OabTu1A@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 20, 2025 at 12:03 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Thu, Nov 20, 2025 at 9:02 AM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> > V6 looks better.
>
> +1. Thanks for updating the patch!
>
> +<phrase>and <replaceable class="parameter">table</replaceable> is:</phrase>
> +
> + [ ONLY ] <replaceable class="parameter">table_name</replaceable> [ * ]
>
> I have one question: in lock.sgml and truncate.sgml, the syntax
> "[ ONLY ] name [ * ] [, ... ]" seems shown as acceptable (though
> I'm not entirely sure it's actually valid). If that form is allowed,
> then this change may not be necessary?
>

I think if this were strict BNF rules, then the bindings of the "..."
are not correct. I think the Postgres documentation is a bit loose
with the rules (e.g. your TRUNCATE example is deemed acceptable)

A user might also wonder if "ONLY a,b" means the same as "ONLY a", "ONLY b"?

But, in the interest of not bloating the ALTER PUBLICATION synopsis
too much, and still being consistent with what seems accepted by
existing PG docs, I am happy to remove that extra 'table' replacement
class. Maybe it's a bit ambiguous, but it seems mostly harmless.

Thoughts?

======
Kind Regards,
Peter Smith.
Fujitsu Australia

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Neil Chen 2025-11-20 01:49:51 Re: Use strtoi64() in pgbench, replacing its open-coded implementation
Previous Message Japin Li 2025-11-20 01:39:36 Re: [PATCH] Add pg_get_database_ddl() function to reconstruct CREATE DATABASE statement