| From: | Yaphters W <yaphters(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Rename 'lpp' to 'lp' in heapam.c |
| Date: | 2023-05-03 00:15:59 |
| Message-ID: | CAHi_D_YPh8Hgs1sK26vruuNjH-zwNK8j0QP4TapieU9HiCU9Vw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
I just found the naming of the ItemId variables is not consistent in
heapam.c. There are 13 'lpp's and 112 'lp's. Technically 'lpp' is correct
as ItemId is a line pointer's pointer and there used to be code like
"++lpp" for line pointer array iteration. Now that all the "++lpp" code has
been removed and there are 100+ more occurrences of 'Ip' than 'lpp', I
suggest we change 'lpp' to 'lp' to make things consistent and avoid
confusion.
Best Regards,
Zian Wang
| Attachment | Content-Type | Size |
|---|---|---|
| v-1-0001-Rename-lpp-to-lp-in-heapam.c.patch | application/octet-stream | 3.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2023-05-03 01:46:15 | Re: [PATCH] Clarify the behavior of the system when approaching XID wraparound |
| Previous Message | Peter Geoghegan | 2023-05-02 21:00:41 | Re: Overhauling "Routine Vacuuming" docs, particularly its handling of freezing |