| From: | Catalin Iacob <iacobcatalin(at)gmail(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: proposal: PL/Pythonu - function ereport |
| Date: | 2016-01-12 16:59:30 |
| Message-ID: | CAHg_5gq5Avebmws_UwNdG97q_66i=Zyogitey_dHi+BNvFqTjQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 12, 2016 at 5:50 PM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> Error and Fatal exception classes are introduced in my patch - it was Peter'
> request (if I remember it well), and now I am thinking so it is not good
> idea.
Now everybody is confused :). Your patch does:
- PLy_exc_error = PyErr_NewException("plpy.Error", NULL, NULL);
- PLy_exc_fatal = PyErr_NewException("plpy.Fatal", NULL, NULL);
- PLy_exc_spi_error = PyErr_NewException("plpy.SPIError", NULL, NULL);
[snip]
+ PLy_exc_error = PyErr_NewException("plpy.Error", PLy_exc_base, NULL);
+ PLy_exc_fatal = PyErr_NewException("plpy.Fatal", PLy_exc_base, NULL);
+ PLy_exc_spi_error = PyErr_NewException("plpy.SPIError",
PLy_exc_base, NULL);
So they are there without the patch, you now make them inherit from
the new BaseError previously they just inherited from Exception.
More soon in another reply I was just typing when this came in.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Anastasia Lubennikova | 2016-01-12 16:59:40 | Re: WIP: Covering + unique indexes. |
| Previous Message | Alvaro Herrera | 2016-01-12 16:54:28 | Re: Support for N synchronous standby servers - take 2 |