Re: [PATCH] Release replication slot on error in SQL-callable slot functions

From: SATYANARAYANA NARLAPURAM <satyanarlapuram(at)gmail(dot)com>
To: shveta malik <shveta(dot)malik(at)gmail(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, shveta malik <shvetamalik(at)gmail(dot)com>
Subject: Re: [PATCH] Release replication slot on error in SQL-callable slot functions
Date: 2026-05-28 01:11:16
Message-ID: CAHg+QDdYJ5+P=QpjvV-w3v7PgviQM5V2PgO5xbK58vd-RrAASw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi

On Wed, May 27, 2026 at 4:00 AM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:

> On Wed, May 27, 2026 at 1:42 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> >
> > On Wed, May 27, 2026 at 1:31 PM SATYANARAYANA NARLAPURAM
> > <satyanarlapuram(at)gmail(dot)com> wrote:
> > > Thank you for the changes and review.
> >
> > When I applied the v4 patch together with Shveta's diff patch and
> > ran the regression tests, the tests failed.
>
> That is because my top-up patch lacks slot.out changes, I wanted Satya
> to first confirm if the changes are acceptable to him. Attached
> another top-up patch for test-output correction.
>

Thanks for the patches, I combined these changes in my latest patch. Please
find the v5.

Thanks,
Satya

Attachment Content-Type Size
v5-0001-Release-replication-slot-on-error-in-slot-SQL-functions.patch application/octet-stream 19.1 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2026-05-28 01:20:03 Re: Proposal: Conflict log history table for Logical Replication
Previous Message Michael Paquier 2026-05-28 01:08:28 Re: [PATCH] Fix ProcKill lock-group vs procLatch recycle race