Re: Add null check on get_tablespace_name() return in pg_get_database_ddl_internal

From: SATYANARAYANA NARLAPURAM <satyanarlapuram(at)gmail(dot)com>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add null check on get_tablespace_name() return in pg_get_database_ddl_internal
Date: 2026-04-23 06:48:28
Message-ID: CAHg+QDcrQHBhGJa9Uc4Q2+Q_uH5=V4QN_twWovrs1PUvFTZdwQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Chao,

On Wed, Apr 22, 2026 at 5:03 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:

>
>
> > On Apr 23, 2026, at 06:20, SATYANARAYANA NARLAPURAM <
> satyanarlapuram(at)gmail(dot)com> wrote:
> >
> > Hi Hackers,
> >
> > A concurrent tablespace drop could lead to null deref in
> pg_get_database_ddl. I acknowledge this is a corner case. Adding a patch to
> fix this to keep the code clean.
> >
> > Thanks,
> > Satya
> >
> <0001-Fix-NULL-deref-in-pg_get_database_ddl-on-concurrent-tablespace-drop.patch>
>
> This is a dup of my recent patch, see [1].
>
> [1]
> https://www.postgresql.org/message-id/573E45C1-31A4-4885-A00C-1A2171159A2A%40gmail.com

Thanks, I replied there.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2026-04-23 06:48:55 Re: [Patch]Add Graph* node support to expression_tree_mutator
Previous Message SATYANARAYANA NARLAPURAM 2026-04-23 06:47:39 Re: Fix a server crash problem from pg_get_database_ddl