| From: | SATYANARAYANA NARLAPURAM <satyanarlapuram(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, efujita(at)postgresql(dot)org |
| Subject: | Fix array-element quoting in postgres_fdw import statistics |
| Date: | 2026-04-12 03:12:58 |
| Message-ID: | CAHg+QDc9=WtYi=JW6QUL6ASOJc6PcGPTuxoMkhnkQ7oi7j5atg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
build_remattrmap() used quote_identifier() to format column names
for a text[] array literal passed to the remote pg_stats query.
quote_identifier() applies SQL identifier quoting, which doubles
double-quote characters but does not escape backslashes. However,
inside a PostgreSQL array literal, backslash is an escape character.
Column names containing backslashes (e.g. "a\b") were silently
mangled by the array parser—"a\b" became "ab"—causing the
WHERE attname = ANY('{...}') filter to miss those columns. The
statistics import would then fail with a WARNING about missing
attribute statistics. This is a very corner cases because usually
backslash is not included in the column names. Anyways attached
a draft patch. Please take a look and let me know what you think.
-- Setup
CREATE TABLE bs_test (id int PRIMARY KEY, "a\b" int, normal_col text);
INSERT INTO bs_test SELECT g, g, 'val' FROM generate_series(1,1000) g;
ANALYZE bs_test;
CREATE SERVER loopback FOREIGN DATA WRAPPER postgres_fdw
OPTIONS (host '127.0.0.1', port '5432', dbname 'testdb', restore_stats
'true');
CREATE USER MAPPING FOR CURRENT_USER SERVER loopback OPTIONS (user
'postgres');
CREATE FOREIGN TABLE fbs_test (id int, "a\b" int, normal_col text)
SERVER loopback OPTIONS (schema_name 'public', table_name 'bs_test');
ANALYZE fbs_test;
-- WARNING: could not import statistics for foreign table "public.fbs_test"
--- no attribute statistics found for column "a\b" of remote table
"public.bs_test"
Thanks,
Satya
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-postgres_fdw-fix-array-quoting.patch | application/octet-stream | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Lakhin | 2026-04-12 06:00:00 | Re: Non-compliant SASLprep implementation for ASCII characters |
| Previous Message | SATYANARAYANA NARLAPURAM | 2026-04-12 01:45:35 | Bug: trailing comma syntax error in postgres_fdw fetch_attstats() |