Re: Typo in create_index regression test

From: Tender Wang <tndrwang(at)gmail(dot)com>
To: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Typo in create_index regression test
Date: 2025-08-04 14:18:38
Message-ID: CAHewXNneA0SGnAUy3+_DTmcT8GY0aHaNdzMD9i386pgZmLh8wQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> 于2025年8月4日周一 22:10写道:

> While looking at create_index.sql, I noticed the following:
>
> --
> -- Check handling of indexes on system columns
> --
> CREATE TABLE syscol_table (a INT);
>
> -- System columns cannot be indexed
> CREATE INDEX ON syscolcol_table (ctid);
>
> which isn't testing what it claims to test because there's a typo in
> the table name. Patch attached.
>

Good catch.
LGTM.

--
Thanks,
Tender Wang

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bertrand Drouvot 2025-08-04 14:20:48 Adding per backend commit and rollback counters
Previous Message Dean Rasheed 2025-08-04 14:10:23 Typo in create_index regression test