| From: | Tender Wang <tndrwang(at)gmail(dot)com> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Kirill Reshke <reshkekirill(at)gmail(dot)com> |
| Subject: | Re: Add SPLIT PARTITION/MERGE PARTITIONS commands |
| Date: | 2026-01-05 11:06:13 |
| Message-ID: | CAHewXNnTghU5u+WBEm=BCDC+6zSpt4o0FVsqMrYHNeUgcdnH5A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Kirill Reshke <reshkekirill(at)gmail(dot)com> 于2025年12月22日周一 13:47写道:
> On Mon, 22 Dec 2025 at 03:02, Alexander Korotkov <aekorotkov(at)gmail(dot)com>
> wrote:
> >
> > On Sun, Dec 21, 2025 at 9:42 AM Kirill Reshke <reshkekirill(at)gmail(dot)com>
> wrote:
>
> > > Hi! Your v2 looks fine
> > > The only question for me is, should we add any regression test to
> exercise this code, or it is not worth the troubles?
> >
> > I've checked contents of out regression tests. I see we very rarely
> > include SQLSTATE there, mostly in psql and plpgsql tests. Thus, I
> > think we should just fix the SQLSTATE without dedicating a test for
> > that. So, I'm going to push the patch from Tender Wang if no
> > objections.
>
>
> Ok, no objections.
>
I added this to [1] commitfest in case we forgot this little issue.
[1] https://commitfest.postgresql.org/patch/6376/
--
Thanks,
Tender Wang
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2026-01-05 11:18:50 | Re: Proposal: Conflict log history table for Logical Replication |
| Previous Message | Tender Wang | 2026-01-05 10:59:12 | Re: Planner : anti-join on left joins |