Re: satisfies_hash_partition crash

From: Tender Wang <tndrwang(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: satisfies_hash_partition crash
Date: 2026-07-02 01:22:30
Message-ID: CAHewXNmYE-SGnppr=vDAhDUNCg3SF-NosjYqHrh9npAh8MuacA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> 于2026年7月2日周四 03:11写道:
>
> Hi,
>
> This test case crashes the server for me:
>
> CREATE TABLE hp (a int) PARTITION BY HASH (a);
> SELECT satisfies_hash_partition('hp'::regclass, 1, 0, VARIADIC NULL::int[]);
>
> I'm inclined to mostly blame my commit
> f3b0897a1213f46b4d3a99a7f8ef3a4b32e03572, which fixed related problems
> but overlooked this one. I think the fix should be simple, but since
> that commit is from 2017, it will need to be back-patched all the way.

Adding PG_ARGISNULL(3) to the beginning of the if() seems workable.
And the comments need to be adjusted.

--
Thanks,
Tender Wang

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ewan Young 2026-07-02 01:39:42 Re: REPACK CONCURRENTLY fails on tables with generated columns
Previous Message Fujii Masao 2026-07-02 01:05:18 Re: psql: Fix \df tab completion for procedures