| From: | Tender Wang <tndrwang(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | A little cosmetic to convert_VALUES_to_ANY() |
| Date: | 2025-07-27 07:53:12 |
| Message-ID: | CAHewXNmKVEXge0QD4-FyUEvDk95MUVvTzOrkMWFiBM=RQCP-tw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
While debugging the pull-up sublink codes, I noticed the
convert_VALUES_to_ANY().
The function is to convert "where colX in VALUES(xxx)" into SAOP. It
firstly scans the values_list to
make sure no volatile function is in this list, then it scans this
values_list again to check that it
only includes Const items.
We can merge the two scans into one. This can reduce the time complexity
from 2O(n) to O(n).
Also, add a brace for better/more consistent style in the attached patch.
--
Thanks,
Tender Wang
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-A-little-cosmetic-to-convert_VALUES_to_ANY.patch | text/plain | 2.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-07-27 08:51:35 | Re: IndexAmRoutine aminsertcleanup function can be NULL? |
| Previous Message | Fujii Masao | 2025-07-27 07:00:01 | Re: Tab completion for large objects |