| From: | Rui Zhao <zhaorui126(at)gmail(dot)com> |
|---|---|
| To: | Ajin Cherian <itsajin(at)gmail(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Preserve replication origin OIDs in pg_upgrade |
| Date: | 2026-08-27 05:55:04 |
| Message-ID: | CAHWVJhHKd0+8n72c2ZKX14QeowYKacmbTySSKwPMFNCA3s9ogA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Ajin,
v17 applies to master (db2d99323f), builds warning-free, make check 245/245,
pg_upgrade TAP 149/149. The two upgrades from my last mail still pass, and
all three points from it are in.
On the commit message: it says commit-timestamp records "are copied
directly from the old cluster's pg_commit_ts directory", but the copying is
still the pg_commit_ts migration thread's patch -- so "will be copied"
would be the accurate tense.
Typo in the comment that replaced the "distinglish" one, at origin.c:309:
"a status row that exists with remote_ls = 0/0" -> remote_lsn.
Everything else looks good to me.
Regards,
Rui
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ewan Young | 2026-08-27 05:57:59 | Use pg_neg_s*_overflow() for open-coded negation overflow checks |
| Previous Message | Richard Guo | 2026-08-27 05:46:18 | Re: remove_useless_joins vs. bug #19560 |