| From: | David Christensen <david(at)pgguru(dot)net> |
|---|---|
| To: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
| Subject: | Re: [PATCH] GROUP BY ALL |
| Date: | 2025-09-26 15:45:53 |
| Message-ID: | CAHM0NXj1Gv_96WxZkiLKhxJVaYOGcmdZ2hApNcvWQ5HxV84Q=A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 26, 2025 at 6:16 AM David Christensen <david(at)pgguru(dot)net> wrote:
>
>
>
> > On Sep 26, 2025, at 3:45 AM, Andrey Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
> >
> >
> >
> >> On 26 Sep 2025, at 12:02, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> >>
> >> maybe someone wants to take this up again.
> >
> > I've compared my old patch with David's, and his version looks better.
> > If David is not going to work on this in nearest future - I'l like to pick up the work.
> > Either way I'll join as reviewer.
> >
> > Thanks!
>
> I’m interested in picking it up again but would appreciate the review.
Here is a rebased version with a few more tests. I also changed the
main check here to using `!contain_agg_clause` instead of
`!IsA(Aggref))` directly. (This was defined in `optimizer/clauses.h`,
but we already are pulling in `optimizer.h`, so it felt valid to me.)
David
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Add-GROUP-BY-ALL.patch | application/octet-stream | 11.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2025-09-26 15:46:02 | Re: Avoiding roundoff error in pg_sleep() |
| Previous Message | Andres Freund | 2025-09-26 15:38:03 | Re: test_json_parser/002_inline is kind of slow |