| From: | jian he <jian(dot)universality(at)gmail(dot)com> |
|---|---|
| To: | David Christensen <david(at)pgguru(dot)net> |
| Cc: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
| Subject: | Re: [PATCH] GROUP BY ALL |
| Date: | 2025-09-26 16:37:29 |
| Message-ID: | CACJufxEThXCX1QWyNE1gw--uJ4JQJ8f16MFH-kN+Ym3_02azTA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 26, 2025 at 11:46 PM David Christensen <david(at)pgguru(dot)net> wrote:
>
> >
> > I’m interested in picking it up again but would appreciate the review.
>
> Here is a rebased version with a few more tests. I also changed the
> main check here to using `!contain_agg_clause` instead of
> `!IsA(Aggref))` directly. (This was defined in `optimizer/clauses.h`,
> but we already are pulling in `optimizer.h`, so it felt valid to me.)
>
hi.
I only briefly browse the patch text file, so forgive me.
seems missing deparse regress tests
i think you may need one test like:
create view v1 as SELECT b, COUNT(*) FROM t1 GROUP BY ALL;
\sv v1
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Christensen | 2025-09-26 16:56:49 | Re: [PATCH] GROUP BY ALL |
| Previous Message | Masahiko Sawada | 2025-09-26 16:27:28 | Re: Remove unused for_all_tables field from AlterPublicationStmt |