| From: | David Christensen <david(at)pgguru(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
| Subject: | Re: [PATCH] GROUP BY ALL |
| Date: | 2025-09-26 16:13:04 |
| Message-ID: | CAHM0NXgPhe_OF81MyA9ocWZ=b+oEAHtQHoDXw4DverPdbkXzpg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 26, 2025 at 11:05 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> David Christensen <david(at)pgguru(dot)net> writes:
> > Here is a rebased version with a few more tests. I also changed the
> > main check here to using `!contain_agg_clause` instead of
> > `!IsA(Aggref))` directly. (This was defined in `optimizer/clauses.h`,
> > but we already are pulling in `optimizer.h`, so it felt valid to me.)
>
> contain_agg_clause will blow up on a SubLink, so I doubt this is
> gonna be robust.
Fair enough, see that Assert now; easy enough to make a new
expression_tree_walker that only looks for Aggref and short-circuits
SubLink (which I assume is the right behavior here, but might have to
add some more tests/play around with subqueries in the GROUP BY ALL
part).
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Christensen | 2025-09-26 16:17:29 | Re: [PATCH] GROUP BY ALL |
| Previous Message | Tom Lane | 2025-09-26 16:04:54 | Re: [PATCH] GROUP BY ALL |