Re: UTF8 is a better option than US-ASCII for the default encoding of PGStream

From: Chang Chao <charleschung(dot)cn(at)gmail(dot)com>
To: pgsql-jdbc(at)postgresql(dot)org
Subject: Re: UTF8 is a better option than US-ASCII for the default encoding of PGStream
Date: 2015-10-13 08:04:44
Message-ID: CAHLX0udhfrGsXtB=G7tHWP1w0neaaeVu=PMvyavTiN89JEmG0Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc

After some googling,found that the same issue was already discussed before.
http://postgresql.nabble.com/JDBC-Default-Encoding-td2172427.html
So to prevent the error message text garbling,we have to change the value
of lc_messages from 'ja_JP.UTF-8' to "en_US.UTF8"?

On Tue, Oct 13, 2015 at 4:48 PM, Chang Chao <charleschung(dot)cn(at)gmail(dot)com>
wrote:

> Hi,all
> The problem I encountered is that,when lc_messages = 'ja_JP.UTF-8' is set
> in postgresql.conf,and initial connection to database server failed(for
> example:user name,password or dbname is misspelled),I see garbled error
> message text in the client .The reason is that,in PGStream
> constrcutor,default encoding of ASCII is
> set(Encoding.getJVMEncoding("US-ASCII")).For the following reasons,maybe
> UTF8 is a better option for default encoding.
>
> 1.When initializing connection ,jdbcclient send client_encoding parameter
> as UTF-8
> see
> org.postgresql.core.v3.ConnectionFactoryImpl.openConnectionImpl(HostSpec[],
> String, String, Properties, Logger)
>
> 2. When initial connection to server completes,jdbc client only receive
> the value for client_encoding as UTF-8
> see
> org.postgresql.core.v3.ConnectionFactoryImpl.readStartupMessages(PGStream,
> ProtocolConnectionImpl, Logger)
>
> if (name.equals("client_encoding"))
> {
> if (!value.equals("UTF8"))
> throw new PSQLException(GT.tr("Protocol error.
> Session setup failed."), PSQLState.PROTOCOL_VIOLATION);
>
> pgStream.setEncoding(Encoding.getDatabaseEncoding("UTF8"));
> }
>
> So there seems no reason to initiate the encoding as US-ASCII.
>
> Best regards.
> Chao.
>

In response to

Responses

Browse pgsql-jdbc by date

  From Date Subject
Next Message Álvaro Hernández Tortosa 2015-10-13 09:18:33 Re: UTF8 is a better option than US-ASCII for the default encoding of PGStream
Previous Message Chang Chao 2015-10-13 07:48:04 UTF8 is a better option than US-ASCII for the default encoding of PGStream