Re: Race between KeepFileRestoredFromArchive() and restartpoint

From: Don Seiler <don(at)seiler(dot)us>
To: David Steele <david(at)pgmasters(dot)net>
Cc: Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers(at)postgresql(dot)org, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Subject: Re: Race between KeepFileRestoredFromArchive() and restartpoint
Date: 2022-08-02 21:03:42
Message-ID: CAHJZqBBMjeL3xi3Yr17_uSNjNvJJdXBKgrWnuRAHJec9usA1sA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 2, 2022 at 10:01 AM David Steele <david(at)pgmasters(dot)net> wrote:

>
> > That makes sense. Each iteration of the restartpoint recycle loop has a
> 1/N
> > chance of failing. Recovery adds >N files between restartpoints.
> Hence, the
> > WAL directory grows without bound. Is that roughly the theory in mind?
>
> Yes, though you have formulated it better than I had in my mind.
>
> Let's see if Don can confirm that he is seeing the "could not link file"
> messages.

During my latest incident, there was only one occurrence:

could not link file “pg_wal/xlogtemp.18799" to
> “pg_wal/000000010000D45300000010”: File exists

WAL restore/recovery seemed to continue on just fine then. And it would
continue on until the pg_wal volume ran out of space unless I was manually
rm'ing already-recovered WAL files from the side.

--
Don Seiler
www.seiler.us

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jacob Champion 2022-08-02 21:05:41 Re: Consider parallel for lateral subqueries with limit
Previous Message Jacob Champion 2022-08-02 21:03:39 Re: Patch to avoid orphaned dependencies