| From: | Don Seiler <don(at)seiler(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] Include application_name in "connection authorized" log message |
| Date: | 2018-08-07 13:31:38 |
| Message-ID: | CAHJZqBAC_HWNx2G39FTZQ=X-Sk0oE59rOt+tHszR401KenHpjw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jul 30, 2018 at 5:20 AM, Peter Eisentraut <
peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> On 13/07/2018 20:20, Don Seiler wrote:
> > See attached for latest revision.
>
> This doesn't compile with SSL enabled because there is a comma missing.
>
Hmm I'll check this out tonight. Sorry I wasn't able to get to this until
now.
> This implementation doesn't run the application_name through
> check_application_name(), so it could end up logging application_name
> values that are otherwise not acceptable. I'm not sure of the best way
> to fix that.
Is the concern that any user can set their client's application name value
to any string they want? Is there a reason we can't call
check_application_name() before setting it in the Port struct in
postmaster.c?
Don.
--
Don Seiler
www.seiler.us
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Kuzmenkov | 2018-08-07 13:36:34 | Re: Reopen logfile on SIGHUP |
| Previous Message | Andres Freund | 2018-08-07 13:29:25 | Re: ATTACH/DETACH PARTITION CONCURRENTLY |