Re: BUG #19598: pg_waldump: -s/-e accept out-of-range WAL locations and silently use the low 32 bits

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Zexin Li <lizi(dot)openmind(at)gmail(dot)com>
Cc: pgsql-bugs(at)lists(dot)postgresql(dot)org, malis(at)pgrust(dot)com, ayushtiwari(dot)slg01(at)gmail(dot)com
Subject: Re: BUG #19598: pg_waldump: -s/-e accept out-of-range WAL locations and silently use the low 32 bits
Date: 2026-08-19 17:57:53
Message-ID: CAHGQGwHzDOuR5kzBvX+enZ7N-56Y4cYWHG-JM=46RTGpqW6TMg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Mon, Aug 17, 2026 at 12:23 PM Zexin Li <lizi(dot)openmind(at)gmail(dot)com> wrote:
> You're right, that is better. v2 attached does it that way in
> backup_label.c, and applies the same approach in pg_rewind's
> timeline.c, so the patch no longer touches src/common at all.

Thanks for updating the patch! It looks good to me.
Barring any objections, I will commit it.

Regards,

--
Fujii Masao

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Paquier 2026-08-19 23:37:05 Re: BUG #19632: RULE rewriting crashes with XX000 when RETURNING old/new references a system column
Previous Message Zsolt Parragi 2026-08-19 17:24:04 Re: Possible G2-item at SERIALIZABLE