Re: Remove the refint contrib module (for v20)

On Sat, Jun 6, 2026 at 4:28 AM Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com> wrote:
> 0002 (test-only) teaches AdjustUpgrade.pm to drop the refint
> extension and its leftover tables (pkeys, fkeys, fkeys2) from
> contrib_regression_spi / regression_spi when upgrading from a version
> that still shipped refint, so cross-version pg_upgrade tests don't
> fail dump comparison once v20 opens.
> I followed the existing < 19 btree_gist block style.

In make-based contrib tests with USE_MODULE_DB=1, contrib/spi uses
contrib_regression_autoinc database, since autoinc is the first entry
in MODULES. So, in 0002 patch, shouldn't we also remove
the refint-related objects from contrib_regression_autoinc?

For example:

foreach my $dbname (
'contrib_regression_autoinc',
'contrib_regression_spi',
'regression_spi')
{
next unless $dbnames{$dbname};

_add_st(
$result,
$dbname,
'drop extension if exists refint cascade',
'drop table if exists pkeys, fkeys, fkeys2');
}

Regards,

--
Fujii Masao