Re: Inconsistent use of --slot/-S in pg_receivexlog and pg_recvlogical

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Inconsistent use of --slot/-S in pg_receivexlog and pg_recvlogical
Date: 2014-08-12 10:27:56
Message-ID: CAHGQGwHjFddHLOKN7zx9AYyO+bsGpjTuJRGbAb_t9Jcf3oAE-w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 12, 2014 at 4:50 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> Hi,
>
> I noticed that pg_receivexlog is able to use --slot but not -S, even
> if the code is written this way. Attached is a patch correcting that.
> This makes pg_receivexlog consistent with pg_recvlogical regarding the
> slot option.
> IMHO, this should be backpatched to REL9_4_STABLE.
> Regards,

Looks good to me. And, I could not find the reason why only -S was not
added, in the past discussion.

Anyway, barring any objection, I will commit this.

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2014-08-12 11:01:18 Re: SSL regression test suite
Previous Message Fujii Masao 2014-08-12 10:13:24 Re: pg_receivexlog --status-interval add fsync feedback