| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Matheus Alcantara <matheusssilv97(at)gmail(dot)com> |
| Cc: | pgsql-docs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Clarify INCLUDING COMMENTS behavior in CREATE TABLE and CREATE FOREIGN TABLE docs |
| Date: | 2026-02-19 15:51:04 |
| Message-ID: | CAHGQGwHbgZvjHEFOjLSiUNfcFFCXw5muJBZp9Ko44Uujks70Bg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs |
On Fri, Feb 20, 2026 at 12:10 AM Matheus Alcantara
<matheusssilv97(at)gmail(dot)com> wrote:
>
> On Tue Feb 17, 2026 at 11:36 AM -03, Fujii Masao wrote:
> > Hi,
> >
> >> Comments for the copied columns, constraints, and indexes will be copied.
> >
> > The above current description of INCLUDING COMMENTS in the CREATE TABLE docs
> > appears inaccurate and incomplete. It says that comments on constraints are
> > copied, but in practice only comments on CHECK and NOT NULL constraints
> > are copied; comments on other constraints (such as primary keys) are not.
> > In addition, comments on extended statistics are copied, but this is not
> > documented.
> >
> > The CREATE FOREIGN TABLE docs has a similar omission: comments on extended
> > statistics are also copied, but this is not mentioned.
> >
> > Therefore I'd like to propose the attached patch to clarify the actual behavior
> > of INCLUDING COMMENTS. Thoughts?
> >
>
> Hi, thanks for the patch.
>
> The changes make sense to me, it sounds more clear. I've performed some
> tests and the documentation seems correct about what comments are
> actually copied.
Thanks for the review! Barring any objections, I will commit the patch.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2026-02-20 14:14:12 | Re: Typo |
| Previous Message | Matheus Alcantara | 2026-02-19 15:09:57 | Re: Clarify INCLUDING COMMENTS behavior in CREATE TABLE and CREATE FOREIGN TABLE docs |