Re: psql: avoid over-reading unterminated prompt escapes

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Ishjaap Singh II <ishjaap(dot)singh07(at)gmail(dot)com>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: psql: avoid over-reading unterminated prompt escapes
Date: 2026-11-19 10:59:03
Message-ID: CAHGQGwHarvTv86GHg+CYMy9-s7fdKWK=TaUruQSV7sE2G3Hizg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Oct 25, 2026 at 10:41 PM Ishjaap Singh II
<ishjaap(dot)singh07(at)gmail(dot)com> wrote:
> In a
> normal build it passed both with and without the fix, so it only
> reliably catches this under ASan. Feel free to leave it out if you
> don't think it's worth adding.

I'm inclined to leave out 0002. It doesn't reliably catch the bug
without ASan, and the maintenance cost of an interactive test seems
hard to justify for this small fix.

> This looks ready for committer to me.

0001 looks good to me too.
So, barring any objections, I will commit it.

Regards,

--
Fujii Masao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nazir Bilal Yavuz 2026-11-19 10:59:22 Re: Switching XLog source from archive to streaming when primary available
Previous Message Amit Kapila 2026-11-19 10:48:57 Re: Add a hook for handling logical decoding messages on subscribers.