| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | shihao zhong <zhong950419(at)gmail(dot)com> |
| Cc: | Sami Imseih <samimseih(at)gmail(dot)com>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add missing stats_reset column to pg_stat_database_conflicts view |
| Date: | 2026-03-12 04:50:28 |
| Message-ID: | CAHGQGwHaHnRrz9hqpDdn984mqToJDdkjMRVvEXXgFwCnXJb89Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 11, 2026 at 11:10 PM shihao zhong <zhong950419(at)gmail(dot)com> wrote:
> Thanks for pointing that out. I've added new tests and used git
> format-patch to generate a new patch.
Thanks for updating the patch!
+-- Test that the stats_reset column in pg_stat_database_conflicts is
correctly maintained
+SELECT pg_stat_reset();
+SELECT stats_reset IS NOT NULL AS has_stats_reset
+ FROM pg_stat_database_conflicts WHERE datname = current_database();
Since stats.sql already includes tests verifying that reset works for
pg_stat_database, it might be better to add the test for
pg_stat_database_conflicts alongside those, rather than at the end of
stats.sql. Thought? The attached updated patch does that.
I also fixed some indentation issues in the docs in the patch.
Regards,
--
Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Add-stats_reset-column-to-pg_stat_database_confli.patch | application/octet-stream | 6.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-03-12 06:04:39 | Re: Add missing stats_reset column to pg_stat_database_conflicts view |
| Previous Message | Xuneng Zhou | 2026-03-12 04:39:32 | Re: Streamify more code paths |