| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | surya poondla <suryapoondla4(at)gmail(dot)com> |
| Cc: | pgsql-docs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Clarify log_parameter_max_length docs regarding log_min_duration_statement vs log_duration |
| Date: | 2026-07-15 11:08:16 |
| Message-ID: | CAHGQGwHa-435W3D1S8hCJkHxwSbNLAQZbwBPpY-SBL+kTF401g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs |
On Tue, Jul 14, 2026 at 4:05 AM surya poondla <suryapoondla4(at)gmail(dot)com> wrote:
>
> Hi Fujii,
>
> The current wording in the docs is misleading. +1 to the patch for correcting it.
> log_parameter_max_length only affects the "Parameters: ..." line that appears alongside logged statements in the server log.
> That line is never emitted when only log_duration is turned on. It only shows up when log_min_duration_statement (or a sample-rate variant) is what causes the statement to be logged.
> So the change looks accurate.
Thanks for the review!
> 1. log_min_duration_sample and log_transaction_sample_rate also cause "Parameters:" lines to be emitted, and are therefore
> also affected by log_parameter_max_length. "and related settings" arguably covers them, but if we want the enumeration to be more
> precise than before, would it be worth naming them explicitly? Either way is fine just curious about the rationale.
TBH I'm also fine with either approach.
> 2. This wording was introduced in 0b34e7d307e and is in every supported branch. Should this be back patched?
Yes, I think this should be backpatched to all supported versions.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2026-07-15 13:17:23 | Re: 66.6. Database Page Layout |
| Previous Message | surya poondla | 2026-07-13 19:05:10 | Re: Clarify log_parameter_max_length docs regarding log_min_duration_statement vs log_duration |