Re: Add Information during standby recovery conflicts

On Fri, Jan 8, 2021 at 2:15 PM Drouvot, Bertrand <bdrouvot(at)amazon(dot)com> wrote:
>
> Hi,
>
> On 1/8/21 5:19 AM, Fujii Masao wrote:
> >
> > On 2021/01/08 11:17, Kyotaro Horiguchi wrote:
> >> At Fri, 8 Jan 2021 01:32:11 +0900, Fujii Masao
> >> <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote in
> >>>
> >>> Attached is the updated version of the patch. This can be applied to
> >>> current master.
> >>>
> >>> With the patch, for example, if the startup process waited longer than
> >>> deadlock_timeout for the recovery conflict on the lock, the latter log
> >>> message in the followings would be additionally output.
> >>>
> >>> LOG: recovery still waiting after 1001.223 ms: recovery
> >>> conflict on
> >>> lock
> >>> LOG: recovery finished waiting after 19004.694 ms: recovery
> >>> conflict
> >>> on lock
> >>
> >> + /*
> >> + * Emit the log message if recovery conflict on
> >> buffer pin was resolved but
> >> + * the startup process waited longer than
> >> deadlock_timeout for it.
> >>
> >> The first line is beyond the 80th column.
> >
> > Thanks for pointing out this! This happened because I forgot to run
> > pgindent
> > for bufmgr.c. Attached is the updated version of the patch.
>
> The patch looks good to me.

Thanks for the review! I pushed the patch.

Regards,

--
Fujii Masao