Re: Missing comment block at the top of streamutil.h and receivelog.h

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Missing comment block at the top of streamutil.h and receivelog.h
Date: 2014-08-27 03:31:31
Message-ID: CAHGQGwHW8JZN_S8ZBC-cgj__RBRAbSsBPzGHQ1TzTu0344R=YQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Aug 27, 2014 at 10:34 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Wed, Aug 27, 2014 at 6:10 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> On Tue, Aug 26, 2014 at 11:03 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>> Probably that's a good idea, but do we really need Author: tags? I
>>> know we have those in a few places, but certainly not everywhere, and
>>> as time goes by they tend to be less accurate reflections of who wrote
>>> the latest code (as opposed to the original code). Furthermore, every
>>> time we include them, it tends to increase the demand to add even more
>>> of them because, hey, everybody likes to be acknowledged.
>>
>> Given that I'm the one named in it - nah, just drop it.
> Updated patch updated without any Author tag.

I think that it's better to add an include guard like

#ifndef RECEIVELOG_H
#define RECEIVELOG_H
...
#endif

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-08-27 03:32:07 Re: Similar to csvlog but not really, json logs?
Previous Message Stephen Frost 2014-08-27 03:23:38 Re: Similar to csvlog but not really, json logs?