Re: [doc] pg_ctl: fix wrong description for -l

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Xiaopeng Wang <wxp_728(at)163(dot)com>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Andreas Karlsson <andreas(at)proxel(dot)se>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [doc] pg_ctl: fix wrong description for -l
Date: 2026-04-16 14:38:23
Message-ID: CAHGQGwHV957qNxqddvMiWh4YvSMuZkDq1QQyUU8px5pCTyFCDw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 15, 2026 at 11:28 AM Xiaopeng Wang <wxp_728(at)163(dot)com> wrote:
>
> 在 2026/4/13 13:20, Hayato Kuroda (Fujitsu) 写道:
> > Dear Andres, Fujii-san,
> >
> > Thanks for reviewing. Updated accordingly.
> >
> > Best regards,
> > Hayato Kuroda
> > FUJITSU LIMITED
> >
> +1 to fix the doc.
>
> I just feel the new sentence could be further polished a little bit, like:
>
> If the file does not exist, it is created. By default, the log file is not accessible to other users, though members of the same group may be able to read it depending on the data directory permissions.

"other users" and "members of the same group" sound a bit ambiguous to me.
Would it be clearer to refer explicitly to the cluster owner? For example:

----------------------
Append the server log output to "filename". If the file does not
exist, it is created. By default, only the cluster owner can access
the log file. If group access is enabled in the cluster, users in the
same group as the cluster owner can also read it.
----------------------

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2026-04-16 14:43:04 Re: Reduce build times of pg_trgm GIN indexes
Previous Message Tom Lane 2026-04-16 14:37:51 Re: Reduce build times of pg_trgm GIN indexes