| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: reaper should restart archiver even on standby |
| Date: | 2015-06-12 14:13:38 |
| Message-ID: | CAHGQGwHS3KNxt4iU+cKx-5j2zerAi6+C-ORjVuyBd8aS-j50Eg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 11, 2015 at 1:39 AM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> Fujii Masao wrote:
>
>> Agreed. The attached patch defines the macro to check whether archiver is
>> allowed to start up or not, and uses it everywhere except sigusr1_handler.
>> I made sigusr1_handler use a different condition because only it tries to
>> start archiver in PM_STARTUP postmaster state and it looks a bit messy
>> to add the check of that state into the centralized check condition.
>
> WFM, but do these macros in xlog.h need a one-line comment to state
> their purpose?
Yes, I added the comments and just pushed the patch. Thanks!
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2015-06-12 14:22:48 | Re: git push hook to check for outdated timestamps |
| Previous Message | Tom Lane | 2015-06-12 14:07:55 | Re: Reconsidering the behavior of ALTER COLUMN TYPE |