| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Assertion failure in pgbench |
| Date: | 2025-07-31 15:25:14 |
| Message-ID: | CAHGQGwHJvog9VquDa2Bvi61Q7z4xiQhh5df508f-K3WHS2SzAA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 31, 2025 at 11:03 AM Tatsuo Ishii <ishii(at)postgresql(dot)org> wrote:
> > Yes. When an error occurs and an error response message returned from
> > backend, pgbench will send one more sync message, then sends ROLLBACK
> > if necessary. I think the code above should be changed to call
> > PQgetResult repeatably until it returns NULL.
I was thinking the same. The attached patch implements that approach,
and it seems to eliminate the assertion failure.
> Correction. That would not be a proper fix. Just removing inner
> PQgetResult and the Assert is enough?
Could you explain why you think repeatedly calling PQgetResult
until it returns NULL isn't the right fix?
Regards,
--
Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Fix-assertion-failure-in-pgbench-when-handling-mu.patch | application/octet-stream | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yugo Nagata | 2025-07-31 15:28:30 | Re: Allow to collect statistics on virtual generated columns |
| Previous Message | Sami Imseih | 2025-07-31 15:22:39 | Re: track generic and custom plans in pg_stat_statements |