| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: doc: clarify wal_sender_shutdown_timeout behavior for small values |
| Date: | 2026-08-04 15:11:40 |
| Message-ID: | CAHGQGwHBE3Uz7G81mTfe8TFaM-rczNDAhXWMPYjUNo=DjoTU+A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jul 18, 2026 at 7:39 AM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> Thanks, everyone, for your comments. PFA v3 that attempts to address them all.
Thanks for updating the patch!
I made a few small adjustments on top of v3:
- Revised the commit message to better reflect the current wording.
- Clarified the GUC long description so that pg_settings explains
the difference between -1 and 0.
- Updated the postgresql.conf.sample comments to clarify that -1 disables
the timeout but still waits for catch-up, whereas 0 does not wait for
catch-up.
The main config.sgml documentation is unchanged from v3.
I've attached the updated version. Barring any objections, I'll commit it.
Regards,
--
Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-doc-Clarify-wal_sender_shutdown_timeout-values.patch | application/octet-stream | 5.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Álvaro Herrera | 2026-08-04 15:14:43 | Re: Fix a host of strto*() bugs |
| Previous Message | Ayush Tiwari | 2026-08-04 15:10:53 | Re: Add a pg_wal_preallocate() SQL function to eagerly create future WAL segments |