Re: Patch: Show process IDs of processes holding a lock; show relation and tuple infos of a lock to acquire

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Christian Kruse <christian(at)2ndquadrant(dot)com>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Rajeev rastogi <rajeev(dot)rastogi(at)huawei(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: Patch: Show process IDs of processes holding a lock; show relation and tuple infos of a lock to acquire
Date: 2014-02-04 03:38:02
Message-ID: CAHGQGwH4zAZMp6BfoL4Bcsid7GZoT=Xz9kzD_2dLBr5id9OKFw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Feb 3, 2014 at 8:53 PM, Christian Kruse
<christian(at)2ndquadrant(dot)com> wrote:
> Hi Simon,
>
> On 03/02/14 10:43, Simon Riggs wrote:
>> > Singular:
>> > "The following process is holding the lock: A. The request queue
>> > consists of: B."
>> >
>> > Plural:
>> > "Following processes are holding the lock: A, B. The request queue
>> > consists of: C."
>>
>> Seems too complex. How about this...
>>
>> "Lock holder(s): A. Lock waiter(s) B"
>> "Lock holder(s): A, B. Lock waiter(s) C"
>
> This is basically the same as before, it is even shorter. The
> complaint was that I don't use a whole sentence in this error
> detail. Won't the change fulfill the same complaint?
>
> To be honest, I'd like to stick with your earlier proposal:
>
> Singular:
> Process holding the lock: A. Request queue: B
>
> Plural:
> Processes holding the lock: A, B. Request queue: C, D
>
> This seems to be a good trade-off between project guidelines,
> readability and parsability.

ISTM that the phrase "Request queue" is not used much around the lock.
Using the phrase "wait queue" or Simon's suggestion sound better to at least me.
Thought?

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2014-02-04 04:06:37 Inconsistency between pg_stat_activity and log_duration
Previous Message Craig Ringer 2014-02-04 03:23:29 Re: Prohibit row-security + inheritance in 9.4?