Re: enhance wraparound warnings

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
Cc: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, qiuwenhuifx(at)gmail(dot)com, shinya11(dot)kato(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: enhance wraparound warnings
Date: 2026-08-04 07:26:09
Message-ID: CAHGQGwH-WCnA3kohZSz-VUDvtN=N=wQXd82=wRcQceJckgt=xA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 28, 2026 at 6:43 PM Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> wrote:
> I don't have a strong preference, but I slightly lean toward keeping "space".
> The explicit denominator would make the percentage easier to interpret, and
> "space" itself doesn't seem particularly confusing to me.

So, my understanding of the discussion is:

- Bharath preferred the wording without "space", but said he was fine with
the majority.
- Kyotaro thought the wording with "space" was clearer, because it makes
explicit what the percentage is relative to.
- Nathan had no strong preference.
- Yugo also slightly leaned toward keeping "space".

So, taking these opinions together, I think the wording with "space" is the
better choice here. Unless there are further objections, I plan to commit
the patch with that wording.

> This also replaces "XIDs" with "transaction IDs" in the surrounding explanatory text.
> I'm not sure this change is necessary, since that text is not part of the example output,
> and "XID" is already used elsewhere in the same paragraph.

I've updated 0002 patch as suggested. Thanks for the review!

Regards,

--
Fujii Masao

Attachment Content-Type Size
v4-0001-Clarify-wraparound-warning-percentage-messages.patch application/octet-stream 9.0 KB
v4-0002-doc-Update-XID-wraparound-error-example.patch application/octet-stream 1.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Álvaro Herrera 2026-08-04 07:26:16 Re: Fix ALTER COLUMN ... DROP EXPRESSSION with subpartitions
Previous Message Daniel Gustafsson 2026-08-04 07:19:36 Re: Improve readability of if-statement in dmetaphone.c