Re: Improve checks for GUC recovery_target_xid

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: David Steele <david(at)pgbackrest(dot)org>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Hüseyin Demir <huseyin(dot)d3r(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Improve checks for GUC recovery_target_xid
Date: 2026-03-05 12:42:19
Message-ID: CAHGQGwGuyb--9MBJX__FVJH1=ny0Jh1H+j0Z-_z-28VZy9hK8g@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Mar 5, 2026 at 5:15 PM David Steele <david(at)pgbackrest(dot)org> wrote:
>
> On 3/5/26 12:03, Fujii Masao wrote:
> > On Thu, Mar 5, 2026 at 1:21 PM David Steele <david(at)pgbackrest(dot)org> wrote:
> >> The prior standby is not running because of the invalid config. I
> >> figured it was better to start clean but when I update the
> >> recovery_target_timeline tests I was planning to use the same standby
> >> for all the new tests.
> >
> > Alternatively, we can use $node_primary, since ALTER SYSTEM SET with
> > invalid recovery_target_timeline or recovery_target_xid does not
> > affect the primary.
>
> Well, as it turns out I was using the primary after all because I copied
> your example and forgot to update the host. Seems weird to set these
> GUCs on the primary but as long as we get the expected errors I don't
> suppose it matters.

Thanks for updating the patch! I've pushed the patch.

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2026-03-05 12:54:06 Re: proposal: schema variables
Previous Message shveta malik 2026-03-05 11:52:09 Re: Skipping schema changes in publication