| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: pg_test_timing utility, to measure clock monotonicity and timing |
| Date: | 2012-03-28 14:43:56 |
| Message-ID: | CAHGQGwGtRyX4Qrr-6XkFGpNxcdGs-gBuv4Cqqyco9+kict+j+A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Wed, Mar 28, 2012 at 9:19 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Tue, Mar 27, 2012 at 10:10 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> On Wed, Mar 28, 2012 at 5:17 AM, Robert Haas <rhaas(at)postgresql(dot)org> wrote:
>>> pg_test_timing utility, to measure clock monotonicity and timing cost.
>>
>> When I compiled this, I got a compiler warning. Attached patch
>> silences the warning.
>
> Unfortunately, that *produces* a warning on my machine. Normally, I
> think we handle this using INT64_FORMAT, but the fact that it's %10ld
> here and not just %lld makes that awkward. I guess we maybe need to
> insert some kludgy workaround here - write it into a separate buffer,
> and then blank-pad it, or something like that.
This seems a simplest workaround. How about attached patch?
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| pgtesttiming_int64format.patch | application/octet-stream | 902 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2012-03-28 15:15:01 | Re: Re: [COMMITTERS] pgsql: pg_test_timing utility, to measure clock monotonicity and timing |
| Previous Message | Marko Kreen | 2012-03-28 13:13:16 | Re: Re: [COMMITTERS] pgsql: pg_test_timing utility, to measure clock monotonicity and timing |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2012-03-28 14:44:32 | Re: 9.2 commitfest closure (was Command Triggers, v16) |
| Previous Message | Tom Lane | 2012-03-28 14:32:56 | Re: Cross-backend signals and administration (Was: Re: pg_terminate_backend for same-role) |