Re: [COMMITTERS] pgsql: pg_test_timing utility, to measure clock monotonicity and timing

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: pg_test_timing utility, to measure clock monotonicity and timing
Date: 2012-03-30 12:19:17
Message-ID: CA+Tgmob3VCthzZYBqbaSJN9REHkSpRu=Djg5ORxRLiTxqoTinQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Wed, Mar 28, 2012 at 10:43 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Wed, Mar 28, 2012 at 9:19 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Tue, Mar 27, 2012 at 10:10 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>> On Wed, Mar 28, 2012 at 5:17 AM, Robert Haas <rhaas(at)postgresql(dot)org> wrote:
>>>> pg_test_timing utility, to measure clock monotonicity and timing cost.
>>>
>>> When I compiled this, I got a compiler warning. Attached patch
>>> silences the warning.
>>
>> Unfortunately, that *produces* a warning on my machine.  Normally, I
>> think we handle this using INT64_FORMAT, but the fact that it's %10ld
>> here and not just %lld makes that awkward.  I guess we maybe need to
>> insert some kludgy workaround here - write it into a separate buffer,
>> and then blank-pad it, or something like that.
>
> This seems a simplest workaround. How about attached patch?

Thanks, committed.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2012-03-30 17:49:07 pgsql: Replace printf format %i by %d
Previous Message Robert Haas 2012-03-30 12:19:05 pgsql: pg_test_timing: Lame hack to work around compiler warning.

Browse pgsql-hackers by date

  From Date Subject
Next Message Merlin Moncure 2012-03-30 13:57:12 Re: HTTP Frontend? (and a brief thought on materialized views)
Previous Message Robert Haas 2012-03-30 12:04:16 Re: Optimizing Nested Correlated Queries by decorrelation: GSOC 2012 Project