| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | surya poondla <suryapoondla4(at)gmail(dot)com> |
| Cc: | Daria Lepikhova <daria(dot)n(dot)lepikhova(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Subject: | Re: Incremental backups report progress as if they were full backups |
| Date: | 2026-10-13 15:44:58 |
| Message-ID: | CAHGQGwGpadjy3SGntq9BSb37C4ZwzFf7nq4QnuSvGebD9Gqn9A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 13, 2026 at 5:50 AM surya poondla <suryapoondla4(at)gmail(dot)com> wrote:
>
> Hi Daria,
>
> Thanks for v3.
Thanks for updating the patch!
The documentation clarification below about the relationship between
estimated backup size and compression addresses a separate issue from the
incorrect progress reporting for incremental backups:
+ The approximate size of the archive that will be generated for the
+ tablespace, in kilobytes (1024 bytes), before any server-side
+ compression, if progress report has been requested; otherwise it's
Rather than combining both fixes in one patch, how about splitting them into
two patches? They address separate issues and have different backpatch
ranges. The documentation clarification should be backpatched to v15, where
server-side compression was introduced, while the incremental backup
progress fix should be backpatched to v17.
I've created both patches based on v3 patch and attached them.
For the 0002 patch, I've also made some cosmetic changes and
cleaned up the tests.
Regards,
--
Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-doc-Clarify-that-base-backup-progress-counts-unco.patch | application/octet-stream | 5.7 KB |
| v4-0002-Report-correct-size-estimate-for-incremental-back.patch | application/octet-stream | 8.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Álvaro Herrera | 2026-10-13 15:45:13 | Re: pgsql: Don't trust NOT NULL on virtual generated columns of partitioned |
| Previous Message | shihao zhong | 2026-10-13 15:41:39 | Re: pgsql: Don't trust NOT NULL on virtual generated columns of partitioned |