| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | cca5507 <cca5507(at)qq(dot)com> |
| Cc: | Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Subject: | Re: data_checksums + debug_discard_caches = crash |
| Date: | 2026-08-04 03:47:15 |
| Message-ID: | CAHGQGwGnFfqE3SM4SMe54vMbASmCT4_abO76Mfna3yeeyug9JQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 4, 2026 at 12:22 PM cca5507 <cca5507(at)qq(dot)com> wrote:
>
> > While working on some stress suite I found the issue related to way
> > ProcessSingleRelationByOid access rel->rd_smgr.
> >
> > Patch with fix and test is attached (it is self-explanatory and pretty simple).
>
> Good catch! I verify that the bug exists and your patch fixes it. Patch LGTM!
+1
The code change looks good to me.
Is the new test really necessary? It only covers this specific data-checksums
worker path, while debug_discard_caches can make the test time longer.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | solai v | 2026-08-04 03:50:59 | Re: [SP-]GiST IOS visibility bug (was: Why doens't GiST require super-exclusive lock) |
| Previous Message | Zhijie Hou (Fujitsu) | 2026-08-04 03:45:13 | RE: Parallel INSERT SELECT take 2 |