Re: Correct some doc items due to the REPACK

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Marcos Pegoraro <marcos(at)f10(dot)com(dot)br>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Correct some doc items due to the REPACK
Date: 2026-08-13 07:45:32
Message-ID: CAHGQGwGn6i-n8zrVg2BMJ19jbMM0O2wfv0ZEYa9R8Z6y747iAQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 30, 2026 at 11:37 PM Marcos Pegoraro <marcos(at)f10(dot)com(dot)br> wrote:
>
> Some sentences in the documentation have become strange or incomplete since the REPACK command was added.
>
> Some were not modified because they referred to variants of VACUUM, not specifically about VACUUM FULL

Thanks for the patch! I agree that these docs updates are needed after
adding REPACK.

I updated the patch and attached v2.

Here are the main changes from v1:

- In ddl.sgml, v1 listed REPACK, CLUSTER, and VACUUM FULL directly in
the ctid description. Since other table-rewriting operations can also
change CTIDs, I changed this to describe them as examples using
"such as" rather than trying to enumerate them.

- In maintenance.sgml, v1 mixed REPACK and CLUSTER into text that was
mainly about routine VACUUM and VACUUM FULL. I reworded the relevant
sections to describe VACUUM FULL, CLUSTER, and REPACK as table-rewriting
compaction operations where appropriate. I also clarified the
ACCESS EXCLUSIVE locking behavior, including the special case of
REPACK CONCURRENTLY.

- In monitoring.sgml, v1 only updated the command list for
pg_stat_progress_repack. I also updated the surrounding text so that
the view consistently describes REPACK, CLUSTER, and VACUUM FULL, while
keeping pg_stat_progress_cluster described as the compatibility view.

- In mvcc.sgml, v1 added REPACK to the ACCESS EXCLUSIVE lock list in a
way that made the CONCURRENTLY behavior ambiguous. I changed this to
say that REPACK also acquires this lock mode, while REPACK CONCURRENTLY
acquires it only when swapping the table and index files.

I also made a few minor adjustments to links, wording, and whitespace.

Regards,

--
Fujii Masao

Attachment Content-Type Size
v2-0001-doc-Update-REPACK-related-table-rewrite-documenta.patch application/octet-stream 11.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bertrand Drouvot 2026-08-13 08:09:25 Re: relfilenode statistics
Previous Message Nikhil Sontakke 2026-08-13 07:42:10 Re: Logical replication row filter loses unchanged toasted columns