Re: Suggestion to add --continue-client-on-abort option to pgbench

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
Cc: Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, Rintaro Ikeda <ikedarintarof(at)oss(dot)nttdata(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "slpmcf(at)gmail(dot)com" <slpmcf(at)gmail(dot)com>, "boekewurm+postgres(at)gmail(dot)com" <boekewurm+postgres(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Subject: Re: Suggestion to add --continue-client-on-abort option to pgbench
Date: 2025-09-18 05:37:29
Message-ID: CAHGQGwGmLwdBPWNotZHjpaEhY-28-d4krbt5Q_S5-s-6Y5=2_A@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Sep 18, 2025 at 10:22 AM Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> wrote:
> That makes sense. How about rewriting this like:
>
> However, if the --continue-on-error option is specified and the error occurs in
> an SQL command, the client does not abort and proceeds to the next
> transaction regardless of the error. These cases are reported as "other failures"
> in the output. Note that if the error occurs in a meta-command, the client will
> still abort even when this option is specified.

How about phrasing it like this, based on your version?

----------------------------
A client's run is aborted in case of a serious error; for example, the
connection with the database server was lost or the end of script was reached
without completing the last transaction. The client also aborts
if a meta-command fails, or if an SQL command fails for reasons other than
serialization or deadlock errors when --continue-on-error is not specified.
With --continue-on-error, the client does not abort on such SQL errors
and instead proceeds to the next transaction. These cases are reported
as "other failures" in the output. If the error occurs in a meta-command,
however, the client still aborts even when this option is specified.
----------------------------

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2025-09-18 06:01:12 Re: How can end users know the cause of LR slot sync delays?
Previous Message Amit Kapila 2025-09-18 05:29:14 Re: Reword messages using "as" instead of "because"