| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [bug fix] pg_rewind takes long time because it mistakenly copies data files |
| Date: | 2018-03-05 17:14:56 |
| Message-ID: | CAHGQGwGkitSeoHXeSKqy=_0tG12GCpCbaPDVy5j97rmCW9wvDA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 28, 2018 at 3:58 PM, Tsunakawa, Takayuki
<tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> wrote:
> From: Michael Paquier [mailto:michael(at)paquier(dot)xyz]
>> So I would propose to just do that later. I have looked a second time at
>> your patch, attached is the set of tests I have run:
>
> Thanks so much, that has helped me a lot!
>
>> I have one small comment though. The comment block at the beginning of
>> isRelDataFile() refers to "pg_tblspc/<tblspc oid>/PG_9.4_201403261/".
>> Could you switch that to "pg_tblspc/<tblspc oid>/<tblspc version>"?
>> That's not directly the fault of your patch, but as long as we are on it..
>
> Done, thanks again for marking the CF entry.
Thanks for the patch! Pushed.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Douglas Doole | 2018-03-05 17:21:23 | Re: INOUT parameters in procedures |
| Previous Message | Alex Kane | 2018-03-05 17:01:29 | Re: All Taxi Services need Index Clustered Heap Append |