Re: Fix doc: explanation of how postgres works when OOM killer is invoked

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Takeshi Ideriha <iderihatakeshi(at)gmail(dot)com>
Cc: Manu <manuelreyesbravo(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Fix doc: explanation of how postgres works when OOM killer is invoked
Date: 2026-10-14 11:36:26
Message-ID: CAHGQGwGiFDNmgwJkVC3SFAy+2yxYKMuVixGwWZiCxOo-Ev4PGg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Oct 14, 2026 at 5:33 PM Takeshi Ideriha
<iderihatakeshi(at)gmail(dot)com> wrote:
> But I'd like to focus on correcting the wrong sentence for now.

+1

So, IMO, it's better to omit the OOM score description because it's not
needed to correct the existing text and is already explained later in
the same section.

+ If a child process is terminated, all connections
+ will be terminated and <productname>PostgreSQL</productname> will
+ automatically restart when
+ <link linkend="guc-restart-after-crash"><varname>restart_after_crash</varname></link>
+ is on. If it is off, <productname>PostgreSQL</productname> will stop and
+ must be restarted manually.

This description seems misleading because not all child process
terminations have this effect. For example, terminating the syslogger
does not terminate existing connections. But, to address this,
listing all the exceptions here would be overkill, though. So, how about
using "typically" instead, as follows?

---------------
If a child process is terminated, PostgreSQL will typically terminate
all remaining connections and either recover automatically, if
restart_after_crash is enabled, or shut down. If PostgreSQL shuts
down, it will need to be restarted to recover.
---------------

Regards,

--
Fujii Masao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jakub Wartak 2026-10-14 11:38:17 Re: log XLogPrefetch stats at end of recovery
Previous Message Jakub Wartak 2026-10-14 11:28:30 Re: Continuous re-validation of session credentials