Re: Fix regression in vacuumdb --analyze-in-stages for partitioned tables

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Antonin Houska <ah(at)cybertec(dot)at>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>
Subject: Re: Fix regression in vacuumdb --analyze-in-stages for partitioned tables
Date: 2026-05-29 16:08:21
Message-ID: CAHGQGwGg1+mpnPZCoPB8iJTmz6d-yQfEi2Hz68suH-Gmham0Mw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 29, 2026 at 5:41 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> The fix is very straightforward, just add check for vacopts->mode == MODE_ANALYZE_IN_STAGES. I also added a test. If we had had this test earlier, the regression should have been caught.

Thanks for reporting the issue and providing the patch! The patch
looks good to me.

Regards,

--
Fujii Masao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message ls7777 2026-05-29 16:08:56 Re: Patch for migration of the pg_commit_ts directory
Previous Message Robert Haas 2026-05-29 16:00:46 Re: injection_points: Switch wait/wakeup to use atomics rather than latches